watch: remove NODE_OPTIONS from spawn call to prevent infinite loop#61838
Open
viiktordev wants to merge 3 commits intonodejs:mainfrom
Open
watch: remove NODE_OPTIONS from spawn call to prevent infinite loop#61838viiktordev wants to merge 3 commits intonodejs:mainfrom
viiktordev wants to merge 3 commits intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61838 +/- ##
==========================================
- Coverage 89.74% 89.71% -0.03%
==========================================
Files 675 675
Lines 204735 204797 +62
Branches 39348 39352 +4
==========================================
+ Hits 183737 183738 +1
- Misses 13269 13330 +61
Partials 7729 7729 🚀 New features to boost your workflow:
|
MoLow
requested changes
Feb 16, 2026
Member
MoLow
left a comment
MoLow
left a comment
There was a problem hiding this comment.
Altough this does fix the bug, it has a much wider affect, and it will prevent NODE_OPTIONS usage with --watch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61740
The loop occurs during the child process spawn in watch mode. I removed
NODE_OPTIONSfrom the environment before callingspawn(), and it solved the issue.I also confirmed that all other flags set in NODE_OPTIONS continue to work after the code update.